Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate

[Eric Blake]

On 3/19/20 2:31 PM, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
>
>
>
> Hi,
>
> This series failed the asan build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> export ARCH=x86_64
> make docker-image-fedora V=1 NETWORK=1
> time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
> === TEST SCRIPT END ===
>
>    CC      trace-root.o
>    CC      accel/kvm/trace.o
>    CC      accel/tcg/trace.o
> /tmp/qemu-test/src/util/thread-pool.c:213:5: error: unused variable 
> 'qemu_lockable_auto__COUNTER__' [-Werror,-Wunused-variable]
>      QEMU_LOCK_GUARD(&pool->lock);
>      ^
> /tmp/qemu-test/src/include/qemu/lockable.h:173:29: note: expanded from macro 
> 'QEMU_LOCK_GUARD'

Hmm. This one is a different failure than the other patchew warnings 
about variable redefinition; but is still evidence that it is missing 
your "[PATCH] misc: fix __COUNTER__ macro to be referenced properly". 
At any rate, the fact that we have a compiler warning about an unused 
variable (when in reality it IS used by the auto-cleanup attribute) is 
annoying; we may have to further tweak QEMU_LOCK_GUARD to add an 
__attribute__((unused)) to shut up this particular compiler false positive.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org