Re: Potential Null dereference

[Philippe Mathieu-Daudé]

On 3/24/20 4:05 AM, Mansour Ahmadi wrote:
> Hi,
>
> Nullness of  needs to be checked here:
> https://github.com/qemu/qemu/blob/c532b954d96f96d361ca31308f75f1b95bd4df76/block/commit.c#L221
>
> pstrcpy(bs->exact_filename, sizeof(bs->exact_filename),...
>
>
> While it is done at 2 other locations:
> https://github.com/qemu/qemu/blob/c532b954d96f96d361ca31308f75f1b95bd4df76/block/backup-top.c#L113
> https://github.com/qemu/qemu/blob/c532b954d96f96d361ca31308f75f1b95bd4df76/block/mirror.c#L1477
>
> if(bs->backing== NULL) {return}

Thanks for spotting this. Do you mind sending a patch?

> Thanks,
> Mansour