[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 20/42] nvme: provide the mandatory subnqn field
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v6 20/42] nvme: provide the mandatory subnqn field |
Date: |
Wed, 25 Mar 2020 12:43:55 +0200 |
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote:
> From: Klaus Jensen <address@hidden>
>
> Signed-off-by: Klaus Jensen <address@hidden>
> ---
> hw/block/nvme.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index b40d27cddc46..74061d08fd2e 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -1925,6 +1925,9 @@ static void nvme_init_ctrl(NvmeCtrl *n)
> id->nn = cpu_to_le32(n->num_namespaces);
> id->oncs = cpu_to_le16(NVME_ONCS_WRITE_ZEROS | NVME_ONCS_TIMESTAMP);
>
> + pstrcpy((char *) id->subnqn, sizeof(id->subnqn),
> "nqn.2019-08.org.qemu:");
> + pstrcat((char *) id->subnqn, sizeof(id->subnqn), n->params.serial);
> +
> id->psd[0].mp = cpu_to_le16(0x9c4);
> id->psd[0].enlat = cpu_to_le32(0x10);
> id->psd[0].exlat = cpu_to_le32(0x4);
Reviewed-by: Maxim Levitsky <address@hidden>
Best regards,
Maxim Levitsky
- [PATCH v6 15/42] nvme: additional tracing, (continued)
- [PATCH v6 15/42] nvme: additional tracing, Klaus Jensen, 2020/03/16
- [PATCH v6 12/42] nvme: add support for the get log page command, Klaus Jensen, 2020/03/16
- [PATCH v6 18/42] nvme: support identify namespace descriptor list, Klaus Jensen, 2020/03/16
- [PATCH v6 13/42] nvme: add support for the asynchronous event request command, Klaus Jensen, 2020/03/16
- [PATCH v6 20/42] nvme: provide the mandatory subnqn field, Klaus Jensen, 2020/03/16
- Re: [PATCH v6 20/42] nvme: provide the mandatory subnqn field,
Maxim Levitsky <=
- [PATCH v6 19/42] nvme: enforce valid queue creation sequence, Klaus Jensen, 2020/03/16
- [PATCH v6 22/42] nvme: memset preallocated requests structures, Klaus Jensen, 2020/03/16
- [PATCH v6 21/42] nvme: bump supported version to v1.3, Klaus Jensen, 2020/03/16
- [PATCH v6 24/42] nvme: remove redundant has_sg member, Klaus Jensen, 2020/03/16