[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 37/42] nvme: refactor identify active namespace id list
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v6 37/42] nvme: refactor identify active namespace id list |
Date: |
Wed, 25 Mar 2020 12:58:52 +0200 |
On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote:
> From: Klaus Jensen <address@hidden>
>
> Prepare to support inactive namespaces.
>
> Signed-off-by: Klaus Jensen <address@hidden>
> ---
> hw/block/nvme.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index b89b96990f52..bf9fb500842a 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -1505,16 +1505,16 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n,
> NvmeIdentify *c,
> uint32_t min_nsid = le32_to_cpu(c->nsid);
> uint32_t *list;
> uint16_t ret;
> - int i, j = 0;
> + int j = 0;
>
> trace_nvme_dev_identify_nslist(min_nsid);
>
> list = g_malloc0(data_len);
> - for (i = 0; i < n->num_namespaces; i++) {
> - if (i < min_nsid) {
> + for (int i = 1; i <= n->num_namespaces; i++) {
> + if (i <= min_nsid) {
> continue;
> }
> - list[j++] = cpu_to_le32(i + 1);
> + list[j++] = cpu_to_le32(i);
> if (j == data_len / sizeof(uint32_t)) {
> break;
> }
Reviewed-by: Maxim Levitsky <address@hidden>
Best regards,
Maxim Levitsky
- Re: [PATCH v6 25/42] nvme: refactor dma read/write, (continued)
- [PATCH v6 32/42] nvme: allow multiple aios per command, Klaus Jensen, 2020/03/16
- [PATCH v6 39/42] pci: allocate pci id for nvme, Klaus Jensen, 2020/03/16
- [PATCH v6 37/42] nvme: refactor identify active namespace id list, Klaus Jensen, 2020/03/16
- Re: [PATCH v6 37/42] nvme: refactor identify active namespace id list,
Maxim Levitsky <=
- [PATCH v6 41/42] nvme: remove redundant NvmeCmd pointer parameter, Klaus Jensen, 2020/03/16
- [PATCH v6 38/42] nvme: support multiple namespaces, Klaus Jensen, 2020/03/16
[PATCH v6 40/42] nvme: change controller pci id, Klaus Jensen, 2020/03/16
[PATCH v6 35/42] nvme: handle dma errors, Klaus Jensen, 2020/03/16
[PATCH v6 42/42] nvme: make lba data size configurable, Klaus Jensen, 2020/03/16