qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Compress lines for immediate return


From: Eric Blake
Subject: Re: [PATCH] Compress lines for immediate return
Date: Wed, 1 Apr 2020 10:45:01 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 4/1/20 9:49 AM, Simran Singhal wrote:
Hello Philippe

On Wed, Apr 1, 2020 at 7:26 PM Philippe Mathieu-Daudé <address@hidden>
wrote:

Hi Simran,

On 4/1/20 2:11 PM, Simran Singhal wrote:
Compress two lines into a single line if immediate return statement is
found.

How did you find these changes? Manual audit, some tool?


I wrote coccinelle script to do these changes.


Then is it worth checking in your script to scripts/coccinelle/ to let it be something we can repeatedly rerun in the future to catch more instances? Even if you don't go that far, mentioning the exact rune you used makes it easier to reproduce the patch, or even backport its effects to a different branch.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]