Re: [PATCH v2 02/12] acpi: add aml builder stubs

[Igor Mammedov]

On Fri,  3 Apr 2020 10:04:52 +0200
Gerd Hoffmann <address@hidden> wrote:

> Needed when moving aml builder code to devices.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>

Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  hw/acpi/aml-build-stub.c | 79 ++++++++++++++++++++++++++++++++++++++++
>  hw/acpi/Makefile.objs    |  4 +-
>  2 files changed, 81 insertions(+), 2 deletions(-)
>  create mode 100644 hw/acpi/aml-build-stub.c
> 
> diff --git a/hw/acpi/aml-build-stub.c b/hw/acpi/aml-build-stub.c
> new file mode 100644
> index 000000000000..58b2e162277f
> --- /dev/null
> +++ b/hw/acpi/aml-build-stub.c
> @@ -0,0 +1,79 @@
> +/*
> + * ACPI aml builder stubs for platforms that don't support ACPI.
> + *
> + * Copyright (c) 2006 Fabrice Bellard
> + * Copyright (c) 2016 Red Hat, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include "qemu/osdep.h"
> +#include "hw/acpi/acpi.h"
> +#include "hw/acpi/aml-build.h"
> +
> +void aml_append(Aml *parent_ctx, Aml *child)
> +{
> +}
> +
> +Aml *aml_resource_template(void)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_device(const char *name_format, ...)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_eisaid(const char *str)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_name_decl(const char *name, Aml *val)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t max_base,
> +            uint8_t aln, uint8_t len)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_irq_no_flags(uint8_t irq)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_int(const uint64_t val)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_package(uint8_t num_elements)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_dma(AmlDmaType typ, AmlDmaBusMaster bm, AmlTransferSize sz,
> +             uint8_t channel)
> +{
> +    return NULL;
> +}
> +
> +Aml *aml_buffer(int buffer_size, uint8_t *byte_list)
> +{
> +    return NULL;
> +}
> diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs
> index 777da07f4d70..cab9bcd457dc 100644
> --- a/hw/acpi/Makefile.objs
> +++ b/hw/acpi/Makefile.objs
> @@ -20,6 +20,6 @@ common-obj-$(CONFIG_TPM) += tpm.o
>  common-obj-$(CONFIG_IPMI) += ipmi.o
>  common-obj-$(call lnot,$(CONFIG_IPMI)) += ipmi-stub.o
>  else
> -common-obj-y += acpi-stub.o
> +common-obj-y += acpi-stub.o aml-build-stub.o
>  endif
> -common-obj-$(CONFIG_ALL) += acpi-stub.o acpi-x86-stub.o ipmi-stub.o
> +common-obj-$(CONFIG_ALL) += acpi-stub.o aml-build-stub.o acpi-x86-stub.o 
> ipmi-stub.o