On Apr 15 09:24, Klaus Birkelund Jensen wrote:
On Apr 15 09:19, Philippe Mathieu-Daudé wrote:
On 4/15/20 7:51 AM, Klaus Jensen wrote:
From: Klaus Jensen <address@hidden>
It might seem wierd to implement this feature for an emulated device,
'weird'
Thanks, fixed :)
but it is mandatory to support and the feature is useful for testing
asynchronous event request support, which will be added in a later
patch.
Which patch? I can't find how you set the temperature in this series.
The temperature cannot be changed, but the thresholds can with the Set
Features command (and that can then trigger AERs). That is added in
"nvme: add temperature threshold feature" and "nvme: add support for the
asynchronous event request command" respectively.
There is a test in SPDK that does this.
Oh, I think I misunderstood you.
No, setting the temperature was moved to the "nvme: add support for the
get log page command" patch since that is the patch that actually uses
it. This was on request by Maxim in an earlier review.