|
From: | Eric Blake |
Subject: | Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper |
Date: | Fri, 24 Apr 2020 09:18:19 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 4/24/20 5:02 AM, Max Reitz wrote:
(With the Patchew warning fixed, of course (i.e., we should set ret to -EPERM or something in qcow.c))Er, well, maybe I should have looked into more places. The compiler only warns about that single one because it’s the only place where @ret is really uninitialized, but there are many more where we need to set it: crypto.c, parallels.c, qcow.c, qcow2.c (both hunks), qed.c, sheepdog.c, vdi.c, vhdx.c, and vpc.c. (So basically everywhere but vmdk.c, blockdev.c, and blockjob.c.)
Urgh - so it's even less of a win in terms of reduced lines of code. Still, I'll fix it and post v3.
And now I’m going to get another coffee... Max
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |