Re: [PATCH 9/9] block: Drop unused .bdrv_has_zero_init_truncate

[Richard W.M. Jones]

On Tue, Apr 28, 2020 at 03:29:05PM -0500, Eric Blake wrote:
> Now that there are no clients of bdrv_has_zero_init_truncate, none of
> the drivers need to worry about providing it.
> 
> What's more, this eliminates a source of some confusion: a literal
> reading of the documentation as written in ceaca56f and implemented in
> commit 1dcaf527 claims that a driver which returns 0 for
> bdrv_has_zero_init_truncate() must not return 1 for
> bdrv_has_zero_init(); this condition was violated for parallels, qcow,
> and sometimes for vdi, although in practice it did not matter since
> those drivers also lacked .bdrv_co_truncate.
> 
> Signed-off-by: Eric Blake <address@hidden>
...
> diff --git a/block/ssh.c b/block/ssh.c
> index f9e08a490069..098dbe03c15b 100644
> --- a/block/ssh.c
> +++ b/block/ssh.c
> @@ -1397,7 +1397,6 @@ static BlockDriver bdrv_ssh = {
>      .bdrv_co_create_opts          = ssh_co_create_opts,
>      .bdrv_close                   = ssh_close,
>      .bdrv_has_zero_init           = ssh_has_zero_init,
> -    .bdrv_has_zero_init_truncate  = ssh_has_zero_init,
>      .bdrv_co_readv                = ssh_co_readv,
>      .bdrv_co_writev               = ssh_co_writev,
>      .bdrv_getlength               = ssh_getlength,

This part seems fine, so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/