Re: [PATCH v2 1/4] iotests/283: Use consistent size for source and targe

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/4] iotests/283: Use consistent size for source and targe

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH v2 1/4] iotests/283: Use consistent size for source and target
Date:	Thu, 30 Apr 2020 20:43:09 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

30.04.2020 17:27, Kevin Wolf wrote:

The test case forgot to specify the null-co size for the target node.
When adding a check to backup that both sizes match, this would fail
because of the size mismatch and not the behaviour that the test really
wanted to test.

Fixes: a541fcc27c98b96da187c7d4573f3270f3ddd283
Signed-off-by: Kevin Wolf<address@hidden>


Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 0/4] backup: Make sure that source and target size match, Kevin Wolf, 2020/04/30
- [PATCH v2 2/4] backup: Improve error for bdrv_getlength() failure, Kevin Wolf, 2020/04/30
- [PATCH v2 3/4] backup: Make sure that source and target size match, Kevin Wolf, 2020/04/30
- [PATCH v2 4/4] iotests: Backup with different source/target size, Kevin Wolf, 2020/04/30
- [PATCH v2 1/4] iotests/283: Use consistent size for source and target, Kevin Wolf, 2020/04/30
  - Re: [PATCH v2 1/4] iotests/283: Use consistent size for source and target, Vladimir Sementsov-Ogievskiy <=

Prev by Date: Re: [PATCH v3 14/15] acpi: factor out fw_cfg_add_acpi_dsdt()
Next by Date: Re: [PATCH 4/4] scripts/qmp: Fix QEMU Python scripts path
Previous by thread: [PATCH v2 1/4] iotests/283: Use consistent size for source and target
Next by thread: [PULL 00/15] Block layer patches
Index(es):
- Date
- Thread