[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 26/33] block: Use child_of_bds in remaining places
From: |
Max Reitz |
Subject: |
Re: [PATCH v3 26/33] block: Use child_of_bds in remaining places |
Date: |
Thu, 7 May 2020 11:33:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 06.05.20 19:04, Kevin Wolf wrote:
> Am 18.02.2020 um 13:42 hat Max Reitz geschrieben:
>> Replace child_file by child_of_bds in all remaining places (excluding
>> tests).
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>
>> diff --git a/block/blkreplay.c b/block/blkreplay.c
>> index f97493f45a..71628f4d56 100644
>> --- a/block/blkreplay.c
>> +++ b/block/blkreplay.c
>> @@ -27,8 +27,9 @@ static int blkreplay_open(BlockDriverState *bs, QDict
>> *options, int flags,
>> int ret;
>>
>> /* Open the image file */
>> - bs->file = bdrv_open_child(NULL, options, "image",
>> - bs, &child_file, 0, false, &local_err);
>> + bs->file = bdrv_open_child(NULL, options, "image", bs, &child_of_bds,
>> + BDRV_CHILD_DATA | BDRV_CHILD_PRIMARY,
>> + false, &local_err);
>
> Why isn't blkreplay a filter?
I don’t know, but that’s pre-existing. (It doesn’t set .is_filter.)
I’m afraid I have little insight into what blkreplay actually does. I
thought maybe in conjunction with the whole replay stuff it might turn
out not to be a filter.
So is it a filter? If so, no problem. I suppose we can fix it up in
the same patch that marks mirror-top and commit-top as filters.
Max
signature.asc
Description: OpenPGP digital signature