[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 01/14] qcrypto/core: add generic infrastructure for crypto
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v5 01/14] qcrypto/core: add generic infrastructure for crypto options amendment |
Date: |
Thu, 07 May 2020 22:08:46 +0300 |
On Thu, 2020-05-07 at 11:09 -0500, Eric Blake wrote:
> On 5/7/20 7:54 AM, Maxim Levitsky wrote:
> > This will be used first to implement luks keyslot management.
> >
> > block_crypto_amend_opts_init will be used to convert
> > qemu-img cmdline to QCryptoBlockAmendOptions
> >
> > Signed-off-by: Maxim Levitsky <address@hidden>
> > Reviewed-by: Daniel P. Berrangé <address@hidden>
> > ---
> > +++ b/qapi/crypto.json
> > @@ -309,3 +309,19 @@
> > 'base': 'QCryptoBlockInfoBase',
> > 'discriminator': 'format',
> > 'data': { 'luks': 'QCryptoBlockInfoLUKS' } }
> > +
> > +
> > +
> > +##
> > +# @QCryptoBlockAmendOptions:
> > +#
> > +# The options that are available for all encryption formats
> > +# when amending encryption settings
> > +#
> > +# Since: 5.0
>
> Looks like our mail crossed, my v4 review landed after you sent v5.
> We'll still have to scrub this series for s/5.0/5.1/
Yea, I totally forgot about this :-(
I''l do this now.
Best regards,
Maxim Levitsky
>
> > +##
> > +{ 'union': 'QCryptoBlockAmendOptions',
> > + 'base': 'QCryptoBlockOptionsBase',
> > + 'discriminator': 'format',
> > + 'data': {
> > + } }
> >
>
>
- [PATCH v5 00/14] LUKS: encryption slot management using amend interface, Maxim Levitsky, 2020/05/07
- [PATCH v5 01/14] qcrypto/core: add generic infrastructure for crypto options amendment, Maxim Levitsky, 2020/05/07
- [PATCH v5 02/14] qcrypto/luks: implement encryption key management, Maxim Levitsky, 2020/05/07
- [PATCH v5 03/14] block/amend: add 'force' option, Maxim Levitsky, 2020/05/07
- [PATCH v5 04/14] block/amend: separate amend and create options for qemu-img, Maxim Levitsky, 2020/05/07
- [PATCH v5 05/14] block/amend: refactor qcow2 amend options, Maxim Levitsky, 2020/05/07
- [PATCH v5 06/14] block/crypto: rename two functions, Maxim Levitsky, 2020/05/07
- [PATCH v5 07/14] block/crypto: implement the encryption key management, Maxim Levitsky, 2020/05/07
- [PATCH v5 09/14] iotests: filter few more luks specific create options, Maxim Levitsky, 2020/05/07
- [PATCH v5 11/14] block/core: add generic infrastructure for x-blockdev-amend qmp command, Maxim Levitsky, 2020/05/07
- [PATCH v5 10/14] iotests: qemu-img tests for luks key management, Maxim Levitsky, 2020/05/07
- [PATCH v5 12/14] block/crypto: implement blockdev-amend, Maxim Levitsky, 2020/05/07