qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RFC 21/32] python//machine.py: remove logging configuration


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH RFC 21/32] python//machine.py: remove logging configuration
Date: Thu, 14 May 2020 08:06:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 5/14/20 7:53 AM, John Snow wrote:
Python 3.5 and above do not print a warning when logging is not
configured. As a library, it's best practice to leave logging
configuration to the client executable.

Signed-off-by: John Snow <address@hidden>
---
  python/qemu/lib/machine.py | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/python/qemu/lib/machine.py b/python/qemu/lib/machine.py
index c31bf7cabb..e92afe8649 100644
--- a/python/qemu/lib/machine.py
+++ b/python/qemu/lib/machine.py
@@ -110,9 +110,6 @@ def __init__(self, binary, args=None, wrapper=None, 
name=None,
          self._console_socket = None
          self._remove_files = []
- # just in case logging wasn't configured by the main script:
-        logging.basicConfig()
-
      def __enter__(self):
          return self

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]