[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 9/9] qapi/misc: Restrict device memory commands to machine
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 9/9] qapi/misc: Restrict device memory commands to machine code |
Date: |
Tue, 26 May 2020 10:18:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> Acked-by: Igor Mammedov <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Markus Armbruster <address@hidden>
All patches: drop the /misc from qapi/misc: in the title, if you don't
mind.
Observation:
before series after
machine-target.json 14KiB in 325 lines 15KiB in 370 lines
machine.json 24KiB in 933 lines 43KiB in 1652 lines
misc.json 38KiB in 1552 lines 18KiB in 796 lines
machine.json is becoming too big. Can we move some parts to new modules
instead? Bonus: these modules can then be covered properly in
MAINTAINERS, unlike the machine.json grabbag.
Obvious candidates for moving to new modules:
* PATCH 8 PCI (304 lines)
This stuff belongs to MAINTAINERS section "PCI".
Michael, Marcel, any objections to new qapi/pci.json?
The QMP command code already lives in hw/pci/pci.c: qmp_query_pci().
Elsewhere, we keep QMP command code in files named like
hw/pci/pci-qmp-cmds.c, but that's probably overkill for just one
command.
* PATCH 7 ACPI (154 lines)
This stuff belongs to MAINTAINERS section "ACPI/SMBIOS", I think.
Michael, Igor, any objections to new qapi/acpi.json?
The QMP command code lives in monitor/qmp-cmds.c:
qmp_query_acpi_ospm_status(). If we move the schema part to
acpi.json, we should consider moving the C part to hw/acpi/.
* PATCH 9 memory (131 lines)
MAINTAINERS section? include/hw/mem/memory-device.h is not covered.
hw/mem/memory-device.c is under "ACPI/SMBIOS".
Michael, Igor, should this stuff go into acpi.json, too?
The QMP command code lives in monitor/qmp-cmds.c:
qmp_query_memory_size_summary(). If we move the schema part to
acpi.json, we should consider moving the C part to hw/acpi/.
* Any others?
- Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code, (continued)
- [PATCH v3 5/9] qapi/misc: Restrict query-vm-generation-id command to machine code, Philippe Mathieu-Daudé, 2020/05/25
- [PATCH v3 6/9] qapi/misc: Move query-uuid command to machine code, Philippe Mathieu-Daudé, 2020/05/25
- [PATCH v3 7/9] qapi/misc: Restrict ACPI commands to machine code, Philippe Mathieu-Daudé, 2020/05/25
- [PATCH v3 8/9] qapi/misc: Restrict PCI commands to machine code, Philippe Mathieu-Daudé, 2020/05/25
- [PATCH v3 9/9] qapi/misc: Restrict device memory commands to machine code, Philippe Mathieu-Daudé, 2020/05/25
- Re: [PATCH v3 9/9] qapi/misc: Restrict device memory commands to machine code,
Markus Armbruster <=