|
From: | Eric Blake |
Subject: | Re: [PATCH v3 1/6] iotests: Add extension names to qcow2.py dump |
Date: | Tue, 2 Jun 2020 11:07:58 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/2/20 11:05 AM, Eric Blake wrote: [I hit send too soon...]
+++ b/tests/qemu-iotests/qcow2.py @@ -6,19 +6,36 @@ import string class QcowHeaderExtension: + QCOW2_EXT_MAGIC_BACKING_FORMAT = 0xE2792ACA + QCOW2_EXT_MAGIC_FEATURE_TABLE = 0x6803f857Why the inconsistency between capitalization in these constants?
At least it matches the inconsistency in docs/interop/qcow2.txt; a patch to fix that wouldn't hurt.
Reviewed-by: Eric Blake <eblake@redhat.com>
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |