[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/6] iotests: 194: test also migration of dirty bitmap
From: |
Thomas Huth |
Subject: |
Re: [PATCH v4 4/6] iotests: 194: test also migration of dirty bitmap |
Date: |
Thu, 4 Jun 2020 09:21:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 03/06/2020 10.06, Vladimir Sementsov-Ogievskiy wrote:
> 03.06.2020 10:52, Thomas Huth wrote:
>> On 22/05/2020 00.06, Vladimir Sementsov-Ogievskiy wrote:
>>> Test that dirty bitmap migration works when we deal with mirror.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>> ---
>>> tests/qemu-iotests/194 | 14 ++++++++++----
>>> tests/qemu-iotests/194.out | 6 ++++++
>>> 2 files changed, 16 insertions(+), 4 deletions(-)
>>
>> Hi!
>>
>> This test broke the iotest in the gitlab CI:
>>
>> https://gitlab.com/huth/qemu/-/jobs/578520599#L3780
>>
>> it works again when I revert this commit.
>>
>> Could the test be reworked so that it works in CI pipelines, too?
>> Otherwise, I think it's best if we disable it in the .gitlab-ci.yml
>> file...
[...]
> - Qemu aborted. Not good. Definitely is better to fix it than just
> exclude the test.. I can't reproduce. Could you provide backtrace from
> coredump?
It aborted in block/dirty-bitmap.c, line 295, that's the
"assert(!bdrv_dirty_bitmap_busy(bitmap));" if I got it right.
Full backtrace here:
https://gitlab.com/huth/qemu/-/jobs/580553686#L3638
HTH,
Thomas