[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once |
|
Date: |
Fri, 5 Jun 2020 10:54:09 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/5/20 10:24 AM, David Edmondson wrote:
> On Thursday, 2020-06-04 at 16:52:36 -05, Eric Blake wrote:
>
>> /* Minimum function that returns zero only iff both values are zero.
>
> Not your change, but "only" is unnecessary here (or iff -> if).
Maybe we should teach checkpatch.pl to refuse the idiomatic 'iff',
it is already hard enough for non-native English to read (or write)
technical documentation...