Re: [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields

[Vladimir Sementsov-Ogievskiy]

05.06.2020 23:16, Eric Blake wrote:
> On 6/4/20 12:41 PM, Vladimir Sementsov-Ogievskiy wrote:
> > No need in lists: it's a constant variable.
> >
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >   tests/qemu-iotests/qcow2_format.py | 40 +++++++++++++++---------------
> >   1 file changed, 20 insertions(+), 20 deletions(-)
>
> >           # Version 3 header fields
> > -        [uint64_t, 'mask', 'incompatible_features'],
> > -        [uint64_t, 'mask', 'compatible_features'],
> > -        [uint64_t, 'mask', 'autoclear_features'],
> > -        [uint32_t, '%d',   'refcount_order'],
> > -        [uint32_t, '%d',   'header_length'],
> > -    ]
> > +        (uint64_t, 'mask', 'incompatible_features'),
> > +        (uint64_t, 'mask', 'compatible_features'),
> > +        (uint64_t, 'mask', 'autoclear_features'),
> > +        (uint32_t, '%d',   'refcount_order'),
> > +        (uint32_t, '%d',   'header_length'),
> > +    )
>
> Not for this patch, but noticing it since we're here: should this be taught to 
> list the optional compression_type field that we recently added after 
> header_length?

Good note. And we can use it in corresponding iotest about compression_type. We 
just should carefully check, how header_length field is handled and fix if 
needed. I think, Andrey or I will make an additional patch.

--
Best regards,
Vladimir