Re: [PATCH v5 08/13] qcow2_format.py: separate generic functionality of structure classes

[Eric Blake]

On 6/6/20 3:18 AM, Vladimir Sementsov-Ogievskiy wrote:
> We are going to introduce more Qcow2 structure types, defined like
> QcowHeader. Move generic functionality into base class to be reused for
> further structure classes.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
>   tests/qemu-iotests/qcow2_format.py | 101 +++++++++++++++++++----------
>   1 file changed, 66 insertions(+), 35 deletions(-)
>
> diff --git a/tests/qemu-iotests/qcow2_format.py 
> b/tests/qemu-iotests/qcow2_format.py
> index 28f2bfa63b..898d388b8a 100644
> --- a/tests/qemu-iotests/qcow2_format.py
> +++ b/tests/qemu-iotests/qcow2_format.py
> @@ -1,5 +1,7 @@
>   # Library for manipulations with qcow2 image
>   #
> +# Copyright (c) 2020 Virtuozzo International GmbH.

Deferring the addition of this line until this point in the series is 
fine. Depending on the answer I get to adding any other copyright line 
in 2/ and 3/13, or if that is deferred to later, we can figure out the 
merge conflict by keeping both.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org