Re: [PATCH v6 00/16] acpi: i386 tweaks

[Michael S. Tsirkin]

On Fri, May 15, 2020 at 05:04:05PM +0200, Gerd Hoffmann wrote:
> First batch of microvm patches, some generic acpi stuff.
> Split the acpi-build.c monster, specifically split the
> pc and q35 and pci bits into a separate file which we
> can skip building at some point in the future.


Applied patch 1-7. Rest all look ok but couldn't apply
since they seem to be on top of some other cleanups
which are not upstream. Pls rebased and post and I'll apply.



> v2 changes: leave acpi-build.c largely as-is, move useful
> bits to other places to allow them being reused, specifically:
> 
>  * move isa device generator functions to individual isa devices.
>  * move fw_cfg generator function to fw_cfg.c
> 
> v3 changes: fix rtc, support multiple lpt devices.
> 
> v4 changes:
>  * drop merged patches.
>  * split rtc crs change to separata patch.
>  * added two cleanup patches.
>  * picked up ack & review tags.
> 
> v5 changes:
>  * add comment for rtc crs update.
>  * add even more cleanup patches.
>  * picked up ack & review tags.
> 
> v6 changes:
>  * floppy: move cmos_get_fd_drive_type.
>  * picked up ack & review tags.
> 
> take care,
>   Gerd
> 
> Gerd Hoffmann (16):
>   qtest: allow DSDT acpi table changes
>   acpi: move aml builder code for rtc device
>   acpi: rtc: use a single crs range
>   acpi: serial: don't use _STA method
>   acpi: move aml builder code for serial device
>   acpi: parallel: don't use _STA method
>   acpi: move aml builder code for parallel device
>   acpi: move aml builder code for floppy device
>   floppy: make isa_fdc_get_drive_max_chs static
>   floppy: move cmos_get_fd_drive_type() from pc
>   acpi: move aml builder code for i8042 (kbd+mouse) device
>   acpi: factor out fw_cfg_add_acpi_dsdt()
>   acpi: simplify build_isa_devices_aml()
>   acpi: drop serial/parallel enable bits from dsdt
>   acpi: drop build_piix4_pm()
>   acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.
> 
>  hw/i386/fw_cfg.h                            |   1 +
>  include/hw/block/fdc.h                      |   3 +-
>  include/hw/i386/pc.h                        |   1 -
>  tests/qtest/bios-tables-test-allowed-diff.h |  17 ++
>  hw/block/fdc.c                              | 111 ++++++-
>  hw/char/parallel.c                          |  22 ++
>  hw/char/serial-isa.c                        |  22 ++
>  hw/i386/acpi-build.c                        | 312 +-------------------
>  hw/i386/fw_cfg.c                            |  28 ++
>  hw/i386/pc.c                                |  25 --
>  hw/input/pckbd.c                            |  31 ++
>  hw/rtc/mc146818rtc.c                        |  24 ++
>  stubs/cmos.c                                |   7 +
>  stubs/Makefile.objs                         |   1 +
>  14 files changed, 269 insertions(+), 336 deletions(-)
>  create mode 100644 stubs/cmos.c
> 
> -- 
> 2.18.4