Re: [PATCH v7 0/9] acpi: i386 tweaks

[Michael S. Tsirkin]

On Wed, Jun 10, 2020 at 01:40:02PM +0200, Igor Mammedov wrote:
> On Wed, 10 Jun 2020 11:41:22 +0200
> Gerd Hoffmann <kraxel@redhat.com> wrote:
> 
> > First batch of microvm patches, some generic acpi stuff.
> > Split the acpi-build.c monster, specifically split the
> > pc and q35 and pci bits into a separate file which we
> > can skip building at some point in the future.
> > 
> It looks like series is missing patch to whitelist changed ACPI tables in
> bios-table-test.

Right. Does it pass make check?

> Do we already have test case for microvm in bios-table-test,
> if not it's probably time to add it.

Separately :)

> > v2 changes: leave acpi-build.c largely as-is, move useful
> > bits to other places to allow them being reused, specifically:
> > 
> >  * move isa device generator functions to individual isa devices.
> >  * move fw_cfg generator function to fw_cfg.c
> > 
> > v3 changes: fix rtc, support multiple lpt devices.
> > 
> > v4 changes:
> >  * drop merged patches.
> >  * split rtc crs change to separata patch.
> >  * added two cleanup patches.
> >  * picked up ack & review tags.
> > 
> > v5 changes:
> >  * add comment for rtc crs update.
> >  * add even more cleanup patches.
> >  * picked up ack & review tags.
> > 
> > v6 changes:
> >  * floppy: move cmos_get_fd_drive_type.
> >  * picked up ack & review tags.
> > 
> > v7 changes:
> >  * rebased to mst/pci branch, resolved stubs conflict.
> >  * dropped patches already queued up in mst/pci.
> >  * added missing sign-off.
> >  * picked up ack & review tags.
> > 
> > take care,
> >   Gerd
> > 
> > Gerd Hoffmann (9):
> >   acpi: move aml builder code for floppy device
> >   floppy: make isa_fdc_get_drive_max_chs static
> >   floppy: move cmos_get_fd_drive_type() from pc
> >   acpi: move aml builder code for i8042 (kbd+mouse) device
> >   acpi: factor out fw_cfg_add_acpi_dsdt()
> >   acpi: simplify build_isa_devices_aml()
> >   acpi: drop serial/parallel enable bits from dsdt
> >   acpi: drop build_piix4_pm()
> >   acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.
> > 
> >  hw/i386/fw_cfg.h       |   1 +
> >  include/hw/block/fdc.h |   3 +-
> >  include/hw/i386/pc.h   |   1 -
> >  hw/block/fdc.c         | 111 +++++++++++++++++++++-
> >  hw/i386/acpi-build.c   | 211 ++---------------------------------------
> >  hw/i386/fw_cfg.c       |  28 ++++++
> >  hw/i386/pc.c           |  25 -----
> >  hw/input/pckbd.c       |  31 ++++++
> >  stubs/cmos.c           |   7 ++
> >  stubs/Makefile.objs    |   1 +
> >  10 files changed, 184 insertions(+), 235 deletions(-)
> >  create mode 100644 stubs/cmos.c
> >