|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH 4/5] block, migration: add bdrv_flush_vmstate helper |
Date: | Thu, 18 Jun 2020 13:03:24 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
17.06.2020 00:29, Denis V. Lunev wrote:
if (ret < 0) { return ret; }...attempting it here, at which point it looks like the only reason you need ret2 is to preserve ret long enough...no, I would like to be sure that intermediate state is always cleared at the end. In the next patch I am going to put intermediate buffer to BlockDriverState and thus it has to be removed in any case. May be flush would be a bad name... clean or finalize?
finalize sounds good for me -- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |