Re: [PATCH 37/46] qom: Make functions taking Error ** return bool, not void

[Markus Armbruster]

Eric Blake <eblake@redhat.com> writes:

> On 6/24/20 11:43 AM, Markus Armbruster wrote:
>> See recent commit "error: Document Error API usage rules" for
>> rationale.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
>> @@ -524,25 +527,29 @@ void object_initialize(void *data, size_t size, const 
>> char *typename)
>>       object_initialize_with_type(data, size, type);
>>   }
>>   -void object_initialize_child_with_props(Object *parentobj,
>> +bool object_initialize_child_with_props(Object *parentobj,
>>                                const char *propname,
>>                                void *childobj, size_t size, const char *type,
>>                                Error **errp, ...)
>
> Is it worth tweaking indentation while here?

Can do.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!