Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realiz

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize()
Date:	Thu, 25 Jun 2020 22:09:38 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

24.06.2020 19:43, Markus Armbruster wrote:

macio_newworld_realize() effectively ignores ns->gpio realization
errors, leaking the Error object.  Fortunately, macio_gpio_realize()
can't actually fail.  Tidy up.

Cc: Mark Cave-Ayland<mark.cave-ayland@ilande.co.uk>
Cc: David Gibson<david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster<armbru@redhat.com>



Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 12/46] qemu-option: Factor out helper find_default_by_name(), (continued)
- [PATCH 09/46] error: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2020/06/24
  - Re: [PATCH 09/46] error: Avoid error_propagate() after migrate_add_blocker(), Eric Blake, 2020/06/24
  - Re: [PATCH 09/46] error: Avoid error_propagate() after migrate_add_blocker(), Vladimir Sementsov-Ogievskiy, 2020/06/29
- [PATCH 14/46] qemu-option: Factor out helper opt_create(), Markus Armbruster, 2020/06/24
  - Re: [PATCH 14/46] qemu-option: Factor out helper opt_create(), Eric Blake, 2020/06/24
  - Re: [PATCH 14/46] qemu-option: Factor out helper opt_create(), Vladimir Sementsov-Ogievskiy, 2020/06/29
- [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize(), Markus Armbruster, 2020/06/24
  - Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize(), Eric Blake, 2020/06/24
  - Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize(), David Gibson, 2020/06/24
  - Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize(), Vladimir Sementsov-Ogievskiy <=
- [PATCH 15/46] qemu-option: Tidy up opt_set() not to free arguments on failure, Markus Armbruster, 2020/06/24
  - Re: [PATCH 15/46] qemu-option: Tidy up opt_set() not to free arguments on failure, Eric Blake, 2020/06/24
  - Re: [PATCH 15/46] qemu-option: Tidy up opt_set() not to free arguments on failure, Vladimir Sementsov-Ogievskiy, 2020/06/29
- [PATCH 06/46] error: Avoid error_propagate() when error is not used here, Markus Armbruster, 2020/06/24
  - Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here, Eric Blake, 2020/06/24
    - Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here, Markus Armbruster, 2020/06/25
  - Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here, Vladimir Sementsov-Ogievskiy, 2020/06/26
    - Re: [PATCH 06/46] error: Avoid error_propagate() when error is not used here, Markus Armbruster, 2020/06/27
- [PATCH 13/46] qemu-option: Simplify around find_default_by_name(), Markus Armbruster, 2020/06/24
  - Re: [PATCH 13/46] qemu-option: Simplify around find_default_by_name(), Eric Blake, 2020/06/24

Prev by Date: Re: [PATCH 03/46] qdev: Smooth error checking of qdev_realize() & friends
Next by Date: Re: [PATCH 05/46] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()
Previous by thread: Re: [PATCH 04/46] macio: Tidy up error handling in macio_newworld_realize()
Next by thread: [PATCH 15/46] qemu-option: Tidy up opt_set() not to free arguments on failure
Index(es):
- Date
- Thread