[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 05/44] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize()
From: |
Markus Armbruster |
Subject: |
[PATCH v2 05/44] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize() |
Date: |
Thu, 2 Jul 2020 17:49:21 +0200 |
virtio_crypto_pci_realize() continues after realization of its
"virtio-crypto-device" fails. Only an object_property_set_link()
follows; looks harmless to me. Tidy up anyway: return after failure,
just like virtio_rng_pci_realize() does.
Cc: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Gonglei < arei.gonglei@huawei.com>
---
hw/virtio/virtio-crypto-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-crypto-pci.c b/hw/virtio/virtio-crypto-pci.c
index 72be531c95..0755722288 100644
--- a/hw/virtio/virtio-crypto-pci.c
+++ b/hw/virtio/virtio-crypto-pci.c
@@ -54,7 +54,9 @@ static void virtio_crypto_pci_realize(VirtIOPCIProxy
*vpci_dev, Error **errp)
}
virtio_pci_force_virtio_1(vpci_dev);
- qdev_realize(vdev, BUS(&vpci_dev->bus), errp);
+ if (!qdev_realize(vdev, BUS(&vpci_dev->bus), errp)) {
+ return;
+ }
object_property_set_link(OBJECT(vcrypto),
OBJECT(vcrypto->vdev.conf.cryptodev), "cryptodev",
NULL);
--
2.26.2
- [PATCH v2 11/44] qemu-option: Replace opt_set() by cleaner opt_validate(), (continued)
- [PATCH v2 11/44] qemu-option: Replace opt_set() by cleaner opt_validate(), Markus Armbruster, 2020/07/02
- [PATCH v2 09/44] qemu-option: Simplify around find_default_by_name(), Markus Armbruster, 2020/07/02
- [PATCH v2 13/44] qemu-option: Use returned bool to check for failure, Markus Armbruster, 2020/07/02
- [PATCH v2 01/44] error: Improve examples in error.h's big comment, Markus Armbruster, 2020/07/02
- [PATCH v2 08/44] qemu-option: Factor out helper find_default_by_name(), Markus Armbruster, 2020/07/02
- [PATCH v2 21/44] qom: Use error_reportf_err() instead of g_printerr() in examples, Markus Armbruster, 2020/07/02
- [PATCH v2 05/44] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(),
Markus Armbruster <=
- [PATCH v2 24/44] qom: Don't handle impossible object_property_get_link() failure, Markus Armbruster, 2020/07/02
- [PATCH v2 28/44] qom: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/02
- [PATCH v2 03/44] qdev: Use returned bool to check for qdev_realize() etc. failure, Markus Armbruster, 2020/07/02
- [PATCH v2 29/44] qom: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/02
- [PATCH v2 17/44] qapi: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/02