Re: [PATCH v2 23/44] qom: Crash more nicely on object_property_get

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link(

From:	Eric Blake
Subject:	Re: [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link() failure
Date:	Thu, 2 Jul 2020 12:29:48 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 7/2/20 10:49 AM, Markus Armbruster wrote:

Pass &error_abort instead of NULL where the returned value is
dereferenced or asserted to be non-null.  Drop a now redundant
assertion.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
  hw/core/platform-bus.c     | 6 +++---

Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 25/44] qom: Use return values to check for error where that's simpler, (continued)
- [PATCH v2 43/44] qdev: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/07/02
- [PATCH v2 41/44] error: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2020/07/02
- [PATCH v2 12/44] qemu-option: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/02
- [PATCH v2 14/44] block: Avoid error accumulation in bdrv_img_create(), Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 14/44] block: Avoid error accumulation in bdrv_img_create(), Eric Blake, 2020/07/02
    - Re: [PATCH v2 14/44] block: Avoid error accumulation in bdrv_img_create(), Markus Armbruster, 2020/07/03
  - Re: [PATCH v2 14/44] block: Avoid error accumulation in bdrv_img_create(), Vladimir Sementsov-Ogievskiy, 2020/07/03
- [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link() failure, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link() failure, Eric Blake <=
  - Re: [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link() failure, Vladimir Sementsov-Ogievskiy, 2020/07/03
    - Re: [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link() failure, Markus Armbruster, 2020/07/04
- [PATCH v2 32/44] qdev: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 32/44] qdev: Use returned bool to check for failure, Coccinelle part, Eric Blake, 2020/07/02
- [PATCH v2 34/44] error: Eliminate error_propagate() with Coccinelle, part 1, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 34/44] error: Eliminate error_propagate() with Coccinelle, part 1, Eric Blake, 2020/07/02
    - Re: [PATCH v2 34/44] error: Eliminate error_propagate() with Coccinelle, part 1, Markus Armbruster, 2020/07/03
- [PATCH v2 26/44] qom: Put name parameter before value / visitor parameter, Markus Armbruster, 2020/07/02
  - Re: [PATCH v2 26/44] qom: Put name parameter before value / visitor parameter, Vladimir Sementsov-Ogievskiy, 2020/07/03
    - Re: [PATCH v2 26/44] qom: Put name parameter before value / visitor parameter, Vladimir Sementsov-Ogievskiy, 2020/07/03

Prev by Date: Re: [PATCH v2 17/44] qapi: Use returned bool to check for failure, Coccinelle part
Next by Date: Re: [PATCH v2 28/44] qom: Use returned bool to check for failure, Coccinelle part
Previous by thread: [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link() failure
Next by thread: Re: [PATCH v2 23/44] qom: Crash more nicely on object_property_get_link() failure
Index(es):
- Date
- Thread