Re: [PATCH v2 11/44] qemu-option: Replace opt_set() by cleaner opt_validate()

[Vladimir Sementsov-Ogievskiy]

02.07.2020 18:49, Markus Armbruster wrote:
> opt_set() frees its argument @value on failure.  Slightly unclean;
> functions ideally do nothing on failure.
>
> To tidy this up, move opt_create() from opt_set() into its callers,
> along with the cleanup.  Rename opt_set() to opt_validate(), noting
> its similarity to qemu_opts_validate().  Drop redundant parameter
> @opts; use opt->opts instead.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
> Reviewed-by: Eric Blake<eblake@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir