[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iotests.py: Do not wait() before communicate()

From: Kevin Wolf
Subject: Re: [PATCH] iotests.py: Do not wait() before communicate()
Date: Fri, 3 Jul 2020 09:57:44 +0200

Am 30.06.2020 um 10:37 hat Max Reitz geschrieben:
> Waiting on a process for which we have a pipe will stall if the process
> outputs more data than fits into the OS-provided buffer.  We must use
> communicate() before wait(), and in fact, communicate() perfectly
> replaces wait() already.
> We have to drop the stderr=subprocess.STDOUT parameter from
> subprocess.Popen() in qemu_nbd_early_pipe(), because stderr is passed on
> to the child process, so if we do not drop this parameter, communicate()
> will hang (because the pipe is not closed).
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Thanks, applied to the block branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]