[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error
Date: Fri, 3 Jul 2020 17:16:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 7/3/20 3:23 PM, Peter Maydell wrote:
> On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> As we have no interest in the underlying block geometry,
>> directly call blk_getlength(). We have to care about machines
>> creating SD card with not drive attached (probably incorrect
>> API use). Simply emit a warning when such Frankenstein cards
>> of zero size are reset.
> Which machines create SD cards without a backing block device?

The Aspeed machines:

> I have a feeling that also the monitor "change" and "eject"
> commands can remove the backing block device from the SD card
> object.

This is what I wanted to talk about on IRC. This seems wrong to me,
we should eject the card and destroy it, and recreate a new card
when plugging in another backing block device.

Keep the reparenting on the bus layer, not on the card.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]