qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 29/44] qom: Make functions taking Error ** return bool, no


From: Markus Armbruster
Subject: Re: [PATCH v3 29/44] qom: Make functions taking Error ** return bool, not 0/-1
Date: Mon, 06 Jul 2020 22:07:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:

> On 06.07.2020 11:09, Markus Armbruster wrote:
>> Just for consistency.  Also fix the example in object_set_props()'s
>> documentation.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
> Note, that object_set_props is unused and may be dropped.

True.  It's never been used.  It was added together with
object_set_propv(), probably out of habit to always have both a ... and
the va_list function.

Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]