[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 16/45] hmp: Eliminate a variable in hmp_migrate_set_parameter(
From: |
Markus Armbruster |
Subject: |
[PATCH v4 16/45] hmp: Eliminate a variable in hmp_migrate_set_parameter() |
Date: |
Tue, 7 Jul 2020 18:05:44 +0200 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
monitor/hmp-cmds.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 2b0b58a336..d7810cb564 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1247,7 +1247,6 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict
*qdict)
MigrateSetParameters *p = g_new0(MigrateSetParameters, 1);
uint64_t valuebw = 0;
uint64_t cache_size;
- MultiFDCompression compress_type;
Error *err = NULL;
int val, ret;
@@ -1343,11 +1342,8 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict
*qdict)
break;
case MIGRATION_PARAMETER_MULTIFD_COMPRESSION:
p->has_multifd_compression = true;
- visit_type_MultiFDCompression(v, param, &compress_type, &err);
- if (err) {
- break;
- }
- p->multifd_compression = compress_type;
+ visit_type_MultiFDCompression(v, param, &p->multifd_compression,
+ &err);
break;
case MIGRATION_PARAMETER_MULTIFD_ZLIB_LEVEL:
p->has_multifd_zlib_level = true;
--
2.26.2
- [PATCH v4 30/45] qom: Make functions taking Error ** return bool, not 0/-1, (continued)
- [PATCH v4 30/45] qom: Make functions taking Error ** return bool, not 0/-1, Markus Armbruster, 2020/07/07
- [PATCH v4 14/45] qemu-option: Use returned bool to check for failure, Markus Armbruster, 2020/07/07
- [PATCH v4 20/45] s390x/pci: Fix harmless mistake in zpci's property fid's setter, Markus Armbruster, 2020/07/07
- [PATCH v4 06/45] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), Markus Armbruster, 2020/07/07
- [PATCH v4 07/45] qemu-option: Check return value instead of @err where convenient, Markus Armbruster, 2020/07/07
- [PATCH v4 19/45] qapi: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/07
- [PATCH v4 29/45] qom: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/07
- [PATCH v4 31/45] qdev: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/07
- [PATCH v4 24/45] qom: Don't handle impossible object_property_get_link() failure, Markus Armbruster, 2020/07/07
- [PATCH v4 18/45] qapi: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/07
- [PATCH v4 16/45] hmp: Eliminate a variable in hmp_migrate_set_parameter(),
Markus Armbruster <=
- [PATCH v4 27/45] qom: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/07
- [PATCH v4 38/45] block/parallels: Simplify parallels_open() after previous commit, Markus Armbruster, 2020/07/07
- [PATCH v4 32/45] qdev: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/07
- [PATCH v4 40/45] qapi: Smooth visitor error checking in generated code, Markus Armbruster, 2020/07/07
- [PATCH v4 42/45] error: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2020/07/07
- [PATCH v4 34/45] error: Eliminate error_propagate() with Coccinelle, part 1, Markus Armbruster, 2020/07/07
- [PATCH v4 28/45] qom: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/07
- [PATCH v4 33/45] error: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/07/07
- [PATCH v4 35/45] error: Eliminate error_propagate() with Coccinelle, part 2, Markus Armbruster, 2020/07/07
- [PATCH v4 36/45] error: Eliminate error_propagate() manually, Markus Armbruster, 2020/07/07