qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 01/45] error: Fix examples in error.h's big comment


From: Eric Blake
Subject: Re: [PATCH v4 01/45] error: Fix examples in error.h's big comment
Date: Tue, 7 Jul 2020 13:35:23 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 7/7/20 11:05 AM, Markus Armbruster wrote:
Mark a bad example more clearly.  Fix the error_propagate_prepend()
example.  Add a missing declaration and a second error pileup example.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
---
  include/qapi/error.h | 16 ++++++++++++++--
  1 file changed, 14 insertions(+), 2 deletions(-)


I know you kept my R-b because you only trimmed this in relation to v3, but I agree that this patch is still looking fine.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]