[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 14/47] stream: Deal with filters

From: Andrey Shinkevich
Subject: Re: [PATCH v7 14/47] stream: Deal with filters
Date: Thu, 9 Jul 2020 18:13:39 +0300
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 25.06.2020 18:21, Max Reitz wrote:
Because of the (not so recent anymore) changes that make the stream job
independent of the base node and instead track the node above it, we
have to split that "bottom" node into two cases: The bottom COW node,
and the node directly above the base node (which may be an R/W filter
or the bottom COW node).

Signed-off-by: Max Reitz <mreitz@redhat.com>
  qapi/block-core.json |  4 +++
  block/stream.c       | 63 ++++++++++++++++++++++++++++++++------------
  blockdev.c           |  4 ++-
  3 files changed, 53 insertions(+), 18 deletions(-)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index b20332e592..df87855429 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2486,6 +2486,10 @@
  # On successful completion the image file is updated to drop the backing file
  # and the BLOCK_JOB_COMPLETED event is emitted.
+# In case @device is a filter node, block-stream modifies the first non-filter
+# overlay node below it to point to base's backing node (or NULL if @base was

Forgot one thing. To me, it would be more understandable to read

"...to point to the base as backing node..." because it may be thought as a backing

node of the base.


+# not specified) instead of modifying @device itself.
  # @job-id: identifier for the newly-created block job. If
  #          omitted, the device name will be used. (Since 2.7)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]