[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 00/16] python: add mypy support to python/qemu

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 00/16] python: add mypy support to python/qemu
Date: Tue, 14 Jul 2020 21:25:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 7/10/20 7:22 AM, John Snow wrote:
> Based-on: 20200710050649.32434-1-jsnow@redhat.com
> This series modifies the python/qemu library to comply with mypy --strict,
> pylint, and flake8.
> This requires my "refactor shutdown" patch as a pre-requisite.
> These should all 100% pass.
> John Snow (16):
>   python/qmp.py: Define common types
>   iotests.py: use qemu.qmp type aliases
>   python/qmp.py: re-absorb MonitorResponseError
>   python/qmp.py: Do not return None from cmd_obj
>   python/qmp.py: add casts to JSON deserialization
>   python/qmp.py: add QMPProtocolError

I've applied patches 1 to 6 on python-next, because unfortunately
then patch 7 now conflicts.

We'll merge them in 5.2 with the 'make check-python' rule patch last,
to avoid regressions.



>   python/machine.py: Fix monitor address typing
>   python/machine.py: reorder __init__
>   python/machine.py: Don't modify state in _base_args()
>   python/machine.py: Handle None events in events_wait
>   python/machine.py: use qmp.command
>   python/machine.py: Add _qmp access shim
>   python/machine.py: fix _popen access
>   python/qemu: make 'args' style arguments immutable
>   iotests.py: Adjust HMP kwargs typing
>   python/qemu: Add mypy type annotations

reply via email to

[Prev in Thread] Current Thread [Next in Thread]