[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.1 v2 1/2] qcow2: Implement v2 zero writes with discard
From: |
Kevin Wolf |
Subject: |
Re: [PATCH for-5.1 v2 1/2] qcow2: Implement v2 zero writes with discard if possible |
Date: |
Tue, 21 Jul 2020 16:28:36 +0200 |
Am 21.07.2020 um 15:55 hat Kevin Wolf geschrieben:
> qcow2 version 2 images don't support the zero flag for clusters, so for
> write_zeroes requests, we return -ENOTSUP and get explicit zero buffer
> writes. If the image doesn't have a backing file, we can do better: Just
> discard the respective clusters.
>
> This is relevant for 'qemu-img convert -O qcow2 -n', where qemu-img has
> to assume that the existing target image may contain any data, so it has
> to write zeroes. Without this patch, this results in a fully allocated
> target image, even if the source image was empty.
>
> Reported-by: Nir Soffer <nsoffer@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Oops, forgot to apply this from v1:
Reviewed-by: Max Reitz <mreitz@redhat.com>
The patch is unchanged, so I'll include this when applying.
Kevin