[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 6/7] ide: clear interrupt on command write
From: |
John Snow |
Subject: |
[PATCH 6/7] ide: clear interrupt on command write |
Date: |
Fri, 24 Jul 2020 01:22:59 -0400 |
Not known to fix any bug, but I couldn't help but notice that ATA
specifies that writing to this register should clear an interrupt.
ATA7: Section 5.3.3 (Command register - Effect)
ATA6: Section 7.4.4 (Command register - Effect)
ATA5: Section 7.4.4 (Command register - Effect)
ATA4: Section 7.4.4 (Command register - Effect)
ATA3: Section 5.2.2 (Command register)
Other editions: try searching for the phrase "Writing this register".
Signed-off-by: John Snow <jsnow@redhat.com>
---
hw/ide/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 5f4f004312..e4c69a7fde 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1312,6 +1312,7 @@ void ide_ioport_write(void *opaque, uint32_t addr,
uint32_t val)
default:
case ATA_IOPORT_WR_COMMAND:
ide_clear_hob(bus);
+ qemu_irq_lower(bus->irq);
ide_exec_cmd(bus, val);
break;
}
--
2.26.2
- [PATCH 0/7] IDE: SRST and other fixes, John Snow, 2020/07/24
- [PATCH 2/7] ide: don't tamper with the device register, John Snow, 2020/07/24
- [PATCH 3/7] ide: model HOB correctly, John Snow, 2020/07/24
- [PATCH 1/7] ide: rename cmd_write to ctrl_write, John Snow, 2020/07/24
- [PATCH 6/7] ide: clear interrupt on command write,
John Snow <=
- [PATCH 4/7] ide: reorder set/get sector functions, John Snow, 2020/07/24
- [PATCH 5/7] ide: remove magic constants from the device register, John Snow, 2020/07/24
- [PATCH 7/7] ide: cancel pending callbacks on SRST, John Snow, 2020/07/24