Re: [PATCH v7 28/47] block/null: Implement bdrv_get_allocated_file_size

[Andrey Shinkevich]

On 24.07.2020 11:58, Max Reitz wrote:
> On 20.07.20 17:10, Andrey Shinkevich wrote:
> > On 25.06.2020 18:21, Max Reitz wrote:
> > > It is trivial, so we might as well do it.
> > >
> > > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > > ---
> > >    block/null.c               | 7 +++++++
> > >    tests/qemu-iotests/153.out | 2 +-
> > >    tests/qemu-iotests/184.out | 6 ++++--
> > >    3 files changed, 12 insertions(+), 3 deletions(-)
...
> > > diff --git a/tests/qemu-iotests/184.out b/tests/qemu-iotests/184.out
> > > index 3deb3cfb94..28b104da89 100644
> > > --- a/tests/qemu-iotests/184.out
> > > +++ b/tests/qemu-iotests/184.out
> > > @@ -29,7 +29,8 @@ Testing:
> > >                "image": {
> > >                    "virtual-size": 1073741824,
> > >                    "filename": "json:{\"throttle-group\": \"group0\",
> > > \"driver\": \"throttle\", \"file\": {\"driver\": \"null-co\"}}",
> > > -                "format": "throttle"
> > > +                "format": "throttle",
> > > +                "actual-size": SIZE
> >
> > If we remove the _filter_generated_node_ids() in the current
> > implementation of the test #184, we will get '"actual-size": 0'. It
> > might be more informative when analyzing the output in 184.out.
> You mean _filter_actual_image_size?  Yeah, why not, it doesn’t seem
> necessary here.
>
> Max

Yes Max, you are right, I ment the _filter_actual_image_size. It was my 
copy/paste mistake.

Andrey