[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 13/21] migration/block-dirty-bitmap: simplify dirty_bitmap

From: Eric Blake
Subject: Re: [PATCH v3 13/21] migration/block-dirty-bitmap: simplify dirty_bitmap_load_complete
Date: Fri, 24 Jul 2020 11:11:02 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote:
bdrv_enable_dirty_bitmap_locked() call does nothing, as if we are in
postcopy, bitmap successor must be enabled, and reclaim operation will
enable the bitmap.

So, actually we need just call _reclaim_ in both if branches, and
making differences only to add an assertion seems not really good. The
logic becomes simple: on load complete we do reclaim and that's all.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
  migration/block-dirty-bitmap.c | 25 ++++---------------------
  1 file changed, 4 insertions(+), 21 deletions(-)

Looks like 8-13 are all cleanups with no semantic change. As it makes the later bug fix easier, I'm fine including them in 5.1 if the bug fix is also 5.1 material.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]