[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/18] hw/block/nvme: flush write cache when disabled
From: |
Maxim Levitsky |
Subject: |
Re: [PATCH v3 10/18] hw/block/nvme: flush write cache when disabled |
Date: |
Wed, 29 Jul 2020 14:03:59 +0300 |
User-agent: |
Evolution 3.36.3 (3.36.3-1.fc32) |
On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> If the write cache is disabled with a Set Features command, flush it if
> currently enabled.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> ---
> hw/block/nvme.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 80c7285bc1cf..8fce2ebf69e7 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -1166,6 +1166,10 @@ static uint16_t nvme_set_feature(NvmeCtrl *n, NvmeCmd
> *cmd, NvmeRequest *req)
>
> break;
> case NVME_VOLATILE_WRITE_CACHE:
> + if (!(dw11 & 0x1) && blk_enable_write_cache(n->conf.blk)) {
> + blk_flush(n->conf.blk);
> + }
> +
> blk_set_enable_write_cache(n->conf.blk, dw11 & 1);
> break;
> case NVME_NUMBER_OF_QUEUES:
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Best regards,
Maxim Levitsky
- Re: [PATCH v3 08/18] hw/block/nvme: add support for the asynchronous event request command, (continued)
[PATCH v3 07/18] hw/block/nvme: add support for the get log page command, Klaus Jensen, 2020/07/06
[PATCH v3 09/18] hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h, Klaus Jensen, 2020/07/06
[PATCH v3 10/18] hw/block/nvme: flush write cache when disabled, Klaus Jensen, 2020/07/06
- Re: [PATCH v3 10/18] hw/block/nvme: flush write cache when disabled,
Maxim Levitsky <=
[PATCH v3 11/18] hw/block/nvme: add remaining mandatory controller parameters, Klaus Jensen, 2020/07/06
[PATCH v3 13/18] hw/block/nvme: make sure ncqr and nsqr is valid, Klaus Jensen, 2020/07/06
[PATCH v3 14/18] hw/block/nvme: support identify namespace descriptor list, Klaus Jensen, 2020/07/06
[PATCH v3 12/18] hw/block/nvme: support the get/set features select and save fields, Klaus Jensen, 2020/07/06