[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/16] hw/block/nvme: remove redundant has_sg member
From: |
Minwoo Im |
Subject: |
Re: [PATCH 04/16] hw/block/nvme: remove redundant has_sg member |
Date: |
Thu, 30 Jul 2020 00:29:34 +0900 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
Klaus,
On 20-07-20 13:37:36, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Remove the has_sg member from NvmeRequest since it's redundant.
>
> Also, make sure the request iov is destroyed at completion time.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> hw/block/nvme.c | 11 ++++++-----
> hw/block/nvme.h | 1 -
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index cb236d1c8c46..6a1a1626b87b 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -548,16 +548,20 @@ static void nvme_rw_cb(void *opaque, int ret)
> block_acct_failed(blk_get_stats(n->conf.blk), &req->acct);
> req->status = NVME_INTERNAL_DEV_ERROR;
> }
> - if (req->has_sg) {
> +
> + if (req->qsg.nalloc) {
Personally, I prefer has_xxx or is_xxx to check whether the request is
based on sg or iov as an inline function, but 'nalloc' is also fine to
figure out the meaning of purpose here.
> qemu_sglist_destroy(&req->qsg);
> }
> + if (req->iov.nalloc) {
> + qemu_iovec_destroy(&req->iov);
> + }
> +
Maybe this can be in a separated commit?
Otherwise, It looks good to me.
Thanks,
- [PATCH 01/16] hw/block/nvme: memset preallocated requests structures, (continued)
[PATCH 04/16] hw/block/nvme: remove redundant has_sg member, Klaus Jensen, 2020/07/20
- Re: [PATCH 04/16] hw/block/nvme: remove redundant has_sg member,
Minwoo Im <=
[PATCH 06/16] hw/block/nvme: pass request along for tracing, Klaus Jensen, 2020/07/20
[PATCH 03/16] hw/block/nvme: replace dma_acct with blk_acct equivalent, Klaus Jensen, 2020/07/20
[PATCH 08/16] hw/block/nvme: verify validity of prp lists in the cmb, Klaus Jensen, 2020/07/20
[PATCH 05/16] hw/block/nvme: refactor dma read/write, Klaus Jensen, 2020/07/20