qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qemu-iotests: Fix FilePaths cleanup


From: Nir Soffer
Subject: Re: [PATCH] qemu-iotests: Fix FilePaths cleanup
Date: Fri, 21 Aug 2020 00:55:26 +0300

On Fri, Aug 21, 2020 at 12:40 AM Nir Soffer <nsoffer@redhat.com> wrote:
>
> On Fri, Aug 21, 2020 at 12:33 AM Eric Blake <eblake@redhat.com> wrote:
> >
> > On 8/20/20 4:29 PM, Eric Blake wrote:
> > > On 8/20/20 4:19 PM, Nir Soffer wrote:
> > >> If os.remove() fails to remove one of the paths, for example if the file
> > >> was removed by the test, the cleanup loop would exit silently, without
> > >> removing the rest of the files.
> > >>
> > >> Signed-off-by: Nir Soffer <nsoffer@redhat.com>
> > >> ---
> > >>   dtc                           | 2 +-
> > >>   tests/qemu-iotests/iotests.py | 8 ++++----
> > >>   2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > >
> > > Reviewed-by: Eric Blake <eblake@redhat.com>
> >
> > By the way, what test did you hit this on? If possible, I'd like to add
> > a Fixes: tag pointing to a commit that includes the problem.

I'll send a v2 with a Fixes tag, and few other related fixes.

>
> I did not hit this issue, found it while reviewing another patch,
> while trying to
> understand what FilePath is doing.
>
> The error was introduced in:
>
> commit de263986b5dc7571d12a95305ffc7ddd2f349431
> Author: John Snow <jsnow@redhat.com>
> Date:   Mon Jul 29 16:35:54 2019 -0400
>
>     iotests: teach FilePath to produce multiple paths
>
>     Use "FilePaths" instead of "FilePath" to request multiple files be
>     cleaned up after we leave that object's scope.
>
>     This is not crucial; but it saves a little typing.
>
>     Signed-off-by: John Snow <jsnow@redhat.com>
>     Reviewed-by: Max Reitz <mreitz@redhat.com>
>     Message-id: 20190709232550.10724-16-jsnow@redhat.com
>     Signed-off-by: John Snow <jsnow@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]