[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] block: file-posix: Extract preallocate helpers
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH 1/2] block: file-posix: Extract preallocate helpers |
|
Date: |
Tue, 01 Sep 2020 12:26:28 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 31 Aug 2020 04:01:26 PM CEST, Nir Soffer wrote:
> +static int preallocate_falloc(int fd, int64_t current_length, int64_t offset,
> + Error **errp)
> +{
> +#ifdef CONFIG_POSIX_FALLOCATE
> + int result;
> +
> + if (offset == current_length)
> + return 0;
You can also take the chance to add the missing braces here (there's a
similar warning for the other patch).
Berto