qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qemu-iotests: move check-block back to Makefiles


From: Thomas Huth
Subject: Re: [PATCH] qemu-iotests: move check-block back to Makefiles
Date: Wed, 2 Sep 2020 12:21:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 02/09/2020 10.37, Paolo Bonzini wrote:
> On 02/09/20 10:19, Daniel P. Berrangé wrote:
>> On Wed, Sep 02, 2020 at 04:00:46AM -0400, Paolo Bonzini wrote:
>>> check-block has its own test harness, unlike every other test.  If
>>> we capture its output, as is in general nicer to do without V=1,
>>> there will be no sign of progress.  So for lack of a better option
>>> just move the invocation of the test back to Makefile rules.
>>
>> I expect the correct long term solution here is to stop using the
>> check-block.sh script.  Instead have code which sets up each
>> of the I/O tests as an explicit test target in meson. We could
>> use meson's test grouping features too.
> 
> I'm not sure, "check-acceptance" will never be integrated in Meson, and
> it may well be the same for "check-block".  Actually I wonder if Avocado
> would be a better check-block.sh than check-block.sh.

Wasn't there even some support for the iotests in avocado (or
avocado-vt) at one point in time? ... not sure anymore, Cleber, Wainer,
do you remember?

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]