[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/7] qemu: Block disk hotplug when transient disk option i
From: |
Peter Krempa |
Subject: |
Re: [PATCH v2 6/7] qemu: Block disk hotplug when transient disk option is enabled |
Date: |
Tue, 8 Sep 2020 15:18:41 +0200 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Fri, Aug 28, 2020 at 10:08:36 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
>
> Block disk hotplug when transient disk option is enabled so far.
>
> Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> ---
> src/qemu/qemu_hotplug.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index 2c6c30ce03..1c1b6c3acf 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -1031,6 +1031,12 @@
> qemuDomainAttachDeviceDiskLiveInternal(virQEMUDriverPtr driver,
> return -1;
> }
>
> + if (disk->transient) {
> + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
> + _("transient disk hotplug isn't supported"));
> + return -1;
> + }
Please move this up in the series so that it's in place before enabling
the feature.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 6/7] qemu: Block disk hotplug when transient disk option is enabled,
Peter Krempa <=