[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw
From: |
Thomas Huth |
Subject: |
Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw |
Date: |
Mon, 14 Sep 2020 13:07:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote:
>
>
> On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
>>
>> On 13/09/2020 00.44, Yonggang Luo wrote:
>> > Fixes following tests on msys2/mingw
>> > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c',
> 'pkix_asn1_tab.c',
>> > tasn1, crypto],
>> > 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c',
> 'pkix_asn1_tab.c', 'crypto-tls-psk-helpers.c',
>> > tasn1, crypto],
>> > 'test-io-channel-tls': ['io-channel-helpers.c',
> 'crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c',
>> > tasn1, io, crypto]}
>> > These tests are failure with:
>> > ERROR test-crypto-tlscredsx509 - missing test plan
>> > ERROR test-crypto-tlssession - missing test plan
>> > ERROR test-io-channel-tls - missing test plan
>> >
>> > Because on win32 those test case are all disabled in the header
>> >
>> > Add qemu_socket_pair for cross platform support, convert file system
>> > handling functions to glib
>> > Add qemu_link function instead posix only link function.
>> > Use send ad recv from qemu that convert Windows Socks error
>> > to errno properly.
>> >
>> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com
> <mailto:luoyonggang@gmail.com>>
>> > ---
[...]
>> Where do you've got this code from? It seems like this has been taken
>> from a 3rd party source? E.g.:
>>
>> https://blog.csdn.net/wufuhuai/article/details/79761889
>>
>> What's the license of this new code? ... please clarify such details in
>> the commit description.
>
> The original code have no license information, neither copyleft nor
> copyright, what's your suggestion
> or rewrite it?
>
You can not simply copy code without license information and submit this
as if it was your own! Please never do that again!
With your Signed-off-by line, you basically acknowledge that you've read
and followed the Developer Certificate of Origin:
https://developercertificate.org/
If you haven't done that yet, please do it now!
And for this patch here, I don't think that it is acceptable without
proper license information.
Thomas
- Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows, (continued)
[PATCH v8 14/27] meson: remove empty else and duplicated gio deps, Yonggang Luo, 2020/09/12
[PATCH v8 15/27] vmstate: Fixes test-vmstate.c on msys2/mingw, Yonggang Luo, 2020/09/12
[PATCH v8 16/27] cirrus: Building freebsd in a single short, Yonggang Luo, 2020/09/12
[PATCH v8 17/27] tests: Convert g_free to g_autofree macro in test-logging.c, Yonggang Luo, 2020/09/12