[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] util: include the target address in socket connect failures
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] util: include the target address in socket connect failures |
|
Date: |
Fri, 18 Sep 2020 11:52:34 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/18/20 11:34 AM, Daniel P. Berrangé wrote:
> Reporting "Failed to connect socket" is essentially useless for a user
> attempting to diagnose failure. It needs to include the target addres
> details. Simiarly when failing to create a socket we should include the
Typos "address", "Similarly".
> socket family info, so the user understands what particular feature was
> missing in their kernel build (IPv6, VSock in particular).
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qemu-iotests/162.out | 4 ++--
> util/qemu-sockets.c | 32 +++++++++++++++++++-------------
> 2 files changed, 21 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>