[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 03/14] hw/block/nvme: Introduce the Namespace Types defini
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v5 03/14] hw/block/nvme: Introduce the Namespace Types definitions |
Date: |
Wed, 30 Sep 2020 10:08:01 +0200 |
On Sep 28 11:35, Dmitry Fomichev wrote:
> From: Niklas Cassel <niklas.cassel@wdc.com>
>
> Define the structures and constants required to implement
> Namespace Types support.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> ---
> hw/block/nvme-ns.h | 2 ++
> hw/block/nvme.c | 2 +-
> include/block/nvme.h | 74 +++++++++++++++++++++++++++++++++++---------
> 3 files changed, 63 insertions(+), 15 deletions(-)
>
> diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h
> index 83734f4606..cca23bc0b3 100644
> --- a/hw/block/nvme-ns.h
> +++ b/hw/block/nvme-ns.h
> @@ -21,6 +21,8 @@
>
> typedef struct NvmeNamespaceParams {
> uint32_t nsid;
> + uint8_t csi;
> + QemuUUID uuid;
> } NvmeNamespaceParams;
The motivation behind the NvmeNamespaceParams was to only keep user
visible parameters in this struct.
Can we move csi/uuid to the NvmeNamespace struct?
signature.asc
Description: PGP signature
- [PATCH v5 00/14] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set, Dmitry Fomichev, 2020/09/27
- [PATCH v5 02/14] hw/block/nvme: Add Commands Supported and Effects log, Dmitry Fomichev, 2020/09/27
- [PATCH v5 04/14] hw/block/nvme: Define trace events related to NS Types, Dmitry Fomichev, 2020/09/27
- [PATCH v5 01/14] hw/block/nvme: Report actual LBA data shift in LBAF, Dmitry Fomichev, 2020/09/27
- [PATCH v5 03/14] hw/block/nvme: Introduce the Namespace Types definitions, Dmitry Fomichev, 2020/09/27
- [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types, Dmitry Fomichev, 2020/09/27
- [PATCH v5 06/14] hw/block/nvme: Add support for active/inactive namespaces, Dmitry Fomichev, 2020/09/27
- [PATCH v5 07/14] hw/block/nvme: Make Zoned NS Command Set definitions, Dmitry Fomichev, 2020/09/27
- [PATCH v5 08/14] hw/block/nvme: Define Zoned NS Command Set trace events, Dmitry Fomichev, 2020/09/27
- [PATCH v5 10/14] hw/block/nvme: Introduce max active and open zone limits, Dmitry Fomichev, 2020/09/27
- [PATCH v5 11/14] hw/block/nvme: Support Zone Descriptor Extensions, Dmitry Fomichev, 2020/09/27