Re: [PATCH 1/4] keyval: Parse help options

[Kevin Wolf]

Am 30.09.2020 um 15:42 hat Eric Blake geschrieben:
> On 9/30/20 8:04 AM, Kevin Wolf wrote:
> > Am 29.09.2020 um 19:46 hat Eric Blake geschrieben:
> >> On 9/29/20 12:26 PM, Kevin Wolf wrote:
> >>> This adds a new parameter 'help' to keyval_parse() that enables parsing
> >>> of help options. If NULL is passed, the function behaves the same as
> >>> before. But if a bool pointer is given, it contains the information
> >>> whether an option "help" without value was given (which would otherwise
> >>> either result in an error or be interpreted as the value for an implied
> >>> key).
> >>>
> >>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> >>> ---
> >>
> >>> +++ b/util/keyval.c
> >>
> >> Might be nice to see this before the testsuite changes by tweaking the
> >> git orderfile.
> > 
> > What does your git orderfile look like? I don't know how to exclude
> > tests/ from file type patterns like *.c.
> 
> You can start with scripts/git.orderfile, and temporarily add:
> 
>  # decoding tree specification
>  *.decode
> 
> +# Key files that I want first for this patch
> +util/*.c
> +
>  # code
>  *.c
> 
> or similar.  It's not a show-stopper if you don't, and I concede that
> remembering to do it (and then to revert back to the usual afterwords)
> is not trivial.

Ah, I see. I never did per-patch/series orderfiles, I just have my
generic one that does things like headers before implementation, and
documentation and QAPI schema changes before both.

Kevin

signature.asc
Description: PGP signature