[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] sd: Exhibit support for CMD23
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2] sd: Exhibit support for CMD23 |
Date: |
Mon, 5 Oct 2020 10:03:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Hi Sai,
On 9/16/20 7:51 PM, Sai Pavan Boddu wrote:
> Update 'SCR.CMD_SUPPORT' register with support of CMD23.
>
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> Reported-by: Rahul Thati <rthati@xilinx.com>
> ---
> Changes for V2:
> Fix commit message
>
> hw/sd/sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 0012882..16d1b61 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -335,7 +335,7 @@ static void sd_set_scr(SDState *sd)
> if (sd->spec_version >= SD_PHY_SPECv3_01_VERS) {
> sd->scr[2] |= 1 << 7; /* Spec Version 3.0X */
> }
> - sd->scr[3] = 0x00;
> + sd->scr[3] = 0x2; /* CMD23 supported */
You need to check:
- spec_version >= SD_PHY_SPECv3_01_VERS
- sd->size > SDSC_MAX_CAPACITY
Then you should also update the TRAN_SPEED value in sd_set_csd().
> /* reserved for manufacturer usage */
> sd->scr[4] = 0x00;
> sd->scr[5] = 0x00;
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2] sd: Exhibit support for CMD23,
Philippe Mathieu-Daudé <=