[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/20] python/machine.py: reorder __init__
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 03/20] python/machine.py: reorder __init__ |
|
Date: |
Wed, 7 Oct 2020 06:53:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/7/20 1:58 AM, John Snow wrote:
> Put the init arg handling all at the top, and mostly in order (deviating
> when one is dependent on another), and put what is effectively runtime
> state declaration at the bottom.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine.py | 44 ++++++++++++++++++++++++------------------
> 1 file changed, 25 insertions(+), 19 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH 00/20] python/qemu: strictly typed mypy conversion, pt2, John Snow, 2020/10/06
- [PATCH 01/20] python/qemu: use isort to lay out imports, John Snow, 2020/10/06
- [PATCH 03/20] python/machine.py: reorder __init__, John Snow, 2020/10/06
- [PATCH 02/20] python/machine.py: Fix monitor address typing, John Snow, 2020/10/06
- [PATCH 04/20] python/machine.py: Don't modify state in _base_args(), John Snow, 2020/10/06
- [PATCH 08/20] python/machine.py: fix _popen access, John Snow, 2020/10/06
[PATCH 09/20] python/qemu: make 'args' style arguments immutable, John Snow, 2020/10/06